From e499a69bd092581226b435d08c2cdc5f4e456945 Mon Sep 17 00:00:00 2001 From: vitya Date: Fri, 28 Aug 2026 14:18:24 +0300 Subject: [PATCH] =?UTF-8?q?fix(1436):=20review-routing=20=E2=80=94=20?= =?UTF-8?q?=D0=BF=D0=B0=D1=80=D0=BD=D1=8B=D0=B5=20=D0=98=D0=9B=D0=98=20?= =?UTF-8?q?=D0=B7=D0=BE=D0=BD=D1=82=D0=B8=D0=BA,=20=D0=BD=D0=B5=20BOTH=20(?= =?UTF-8?q?=D0=BE=D0=BF=D0=B5=D1=80=D0=B0=D1=82=D0=BE=D1=80)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- skills/mappa-vitya-brainstorming/SKILL.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/skills/mappa-vitya-brainstorming/SKILL.md b/skills/mappa-vitya-brainstorming/SKILL.md index 09c7820..62d0730 100644 --- a/skills/mappa-vitya-brainstorming/SKILL.md +++ b/skills/mappa-vitya-brainstorming/SKILL.md @@ -53,7 +53,7 @@ become tasks, how many reviews". It passes a **routing decision** to | Where does the buffer live | A mappa `brainstorm` entity (status=buffer). NOT a file. | | When is a storm mature | The buffer-completion criterion, NOT a gut feel. | | Where does the spec/decisions go | A mappa **wiki concept**. Before any wiki work — run `mappa-knowledge` first. | -| Multiple impl tasks | Paired `-review` per impl + an umbrella `-review`. Both blocked, non-implementer. | +| Multiple impl tasks | **ИЛИ**: единичная таска → парная `-review`; кластер из одного шторма → зонтичный `-review` (парные НЕ создаются). Blocked, non-implementer. | | Who implements | ASK who implements (you are not automatically it). Boss does not implement (Rule 10). | | Who notifies | Send an `inbox_send` letter to every affected project. | | Zero-impl storm | Mature when decisions are distilled into a wiki concept; NO review umbrella (criterion holds vacuously). | @@ -87,15 +87,15 @@ first** (Rule 6), it loads the project's AGENTS entity and the read/ingest contract. **5. Review is a separate, non-implementer role.** -When multiple implementation tasks come out of the storm, create BOTH: -- a **paired `-review`** per impl task (status=blocked, blocker=impl-ref); -- an **umbrella `-review`** (status=blocked, blocker=impl-slugs). +Review routing (оператор 2026-08-28): **парные review ИЛИ зонтик** (не BOTH). +- **Единичная импл-таска** из шторма → парная `-review` (status=blocked, blocker=impl-ref), без зонтика. +- **Кластер тасок** из одного шторма → зонтичный `-review` на весь кластер (status=blocked, blocker=impl-slugs); парные на каждую таску НЕ создаются (иначе двойное ревью одного и того же). Reviewer is the next session in the target, **not the implementer** — this fights the "I just wrote it" bias. You (the brainstorming agent) generate the -review tasks; you do NOT do the code review yourself. The umbrella review is -done only when its reviewer confirms — the storm is not mature until the -umbrella `-review` is resolved, not merely created. +review tasks; you do NOT do the code review yourself. The review is done only +when its reviewer confirms — the storm is not mature until the review +(`-review` ИЛИ `-review`) is resolved, not merely created. **6. Ask who implements. Do not assume it's you.** Brainstorms run anywhere by any agent. The implementer is not automatically the @@ -128,7 +128,7 @@ promote skill executes the mappa write/promotion. | "I'll just jot notes in a markdown file" | Buffer must be a mappa brainstorm entity; the file channel is closed. | | "It feels done, let's write it up" | Maturity is the completion criterion, not a feeling. | | "The spec can live in docs/ for now" | Spec goes to a mappa wiki concept; before wiki — run `mappa-knowledge`. | -| "I'll review my own tasks, then hand to the user" | Review is a separate non-implementer role; paired + umbrella. | +| "I'll review my own tasks, then hand to the user" | Review is a separate non-implementer role; парная ИЛИ зонтик (не BOTH). | | "I'm the coding agent, I'll just implement it" | Ask who implements; in the boss zone the boss does not implement. | | "I'll note the impact in the spec, no need to ping" | Notify every affected project with an `inbox_send` letter. |