OpeItcLoc03/skills
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(1436): review-routing — парные ИЛИ зонтик, не BOTH (оператор)

Browse Source
This commit is contained in:
vitya
2026-08-28 14:18:24 +03:00
parent 247abbbf12
commit e499a69bd0
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
skills/mappa-vitya-brainstorming/SKILL.md
View File

@@ -53,7 +53,7 @@ become tasks, how many reviews". It passes a **routing decision** to
| Where does the buffer live | A mappa `brainstorm` entity (status=buffer). NOT a file. | | Where does the buffer live | A mappa `brainstorm` entity (status=buffer). NOT a file. |
| When is a storm mature | The buffer-completion criterion, NOT a gut feel. | | When is a storm mature | The buffer-completion criterion, NOT a gut feel. |
| Where does the spec/decisions go | A mappa **wiki concept**. Before any wiki work — run `mappa-knowledge` first. | | Where does the spec/decisions go | A mappa **wiki concept**. Before any wiki work — run `mappa-knowledge` first. |
| Multiple impl tasks | Paired `<slug>-review` per impl + an umbrella `<topic>-review`. Both blocked, non-implementer. | | Multiple impl tasks | **ИЛИ**: единичная таска → парная `<slug>-review`; кластер из одного шторма → зонтичный `<topic>-review` (парные НЕ создаются). Blocked, non-implementer. |
| Who implements | ASK who implements (you are not automatically it). Boss does not implement (Rule 10). | | Who implements | ASK who implements (you are not automatically it). Boss does not implement (Rule 10). |
| Who notifies | Send an `inbox_send` letter to every affected project. | | Who notifies | Send an `inbox_send` letter to every affected project. |
| Zero-impl storm | Mature when decisions are distilled into a wiki concept; NO review umbrella (criterion holds vacuously). | | Zero-impl storm | Mature when decisions are distilled into a wiki concept; NO review umbrella (criterion holds vacuously). |
@@ -87,15 +87,15 @@ first** (Rule 6), it loads the project's AGENTS entity and the read/ingest
contract. contract.
**5. Review is a separate, non-implementer role.** **5. Review is a separate, non-implementer role.**
When multiple implementation tasks come out of the storm, create BOTH: Review routing (оператор 2026-08-28): **парные review ИЛИ зонтик** (не BOTH).
- a **paired `<slug>-review`** per impl task (status=blocked, blocker=impl-ref); - **Единичная импл-таска** из шторма → парная `<slug>-review` (status=blocked, blocker=impl-ref), без зонтика.
- an **umbrella `<topic>-review`** (status=blocked, blocker=impl-slugs). - **Кластер тасок** из одного шторма → зонтичный `<topic>-review` на весь кластер (status=blocked, blocker=impl-slugs); парные на каждую таску НЕ создаются (иначе двойное ревью одного и того же).
Reviewer is the next session in the target, **not the implementer** — this Reviewer is the next session in the target, **not the implementer** — this
fights the "I just wrote it" bias. You (the brainstorming agent) generate the fights the "I just wrote it" bias. You (the brainstorming agent) generate the
review tasks; you do NOT do the code review yourself. The umbrella review is review tasks; you do NOT do the code review yourself. The review is done only
done only when its reviewer confirms — the storm is not mature until the when its reviewer confirms — the storm is not mature until the review
umbrella `<topic>-review` is resolved, not merely created. (`<slug>-review` ИЛИ `<topic>-review`) is resolved, not merely created.
**6. Ask who implements. Do not assume it's you.** **6. Ask who implements. Do not assume it's you.**
Brainstorms run anywhere by any agent. The implementer is not automatically the Brainstorms run anywhere by any agent. The implementer is not automatically the
@@ -128,7 +128,7 @@ promote skill executes the mappa write/promotion.
| "I'll just jot notes in a markdown file" | Buffer must be a mappa brainstorm entity; the file channel is closed. | | "I'll just jot notes in a markdown file" | Buffer must be a mappa brainstorm entity; the file channel is closed. |
| "It feels done, let's write it up" | Maturity is the completion criterion, not a feeling. | | "It feels done, let's write it up" | Maturity is the completion criterion, not a feeling. |
| "The spec can live in docs/ for now" | Spec goes to a mappa wiki concept; before wiki — run `mappa-knowledge`. | | "The spec can live in docs/ for now" | Spec goes to a mappa wiki concept; before wiki — run `mappa-knowledge`. |
| "I'll review my own tasks, then hand to the user" | Review is a separate non-implementer role; paired + umbrella. | | "I'll review my own tasks, then hand to the user" | Review is a separate non-implementer role; парная ИЛИ зонтик (не BOTH). |
| "I'm the coding agent, I'll just implement it" | Ask who implements; in the boss zone the boss does not implement. | | "I'm the coding agent, I'll just implement it" | Ask who implements; in the boss zone the boss does not implement. |
| "I'll note the impact in the spec, no need to ping" | Notify every affected project with an `inbox_send` letter. | | "I'll note the impact in the spec, no need to ping" | Notify every affected project with an `inbox_send` letter. |